add pagination / filtering / sorting for the plural endpoints#16
Merged
add pagination / filtering / sorting for the plural endpoints#16
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a shared query-processing layer so plural (array) endpoints can support pagination, filtering, and sorting, and updates API docs/tests accordingly.
Changes:
- Introduces
src/core/queryProcessor.tsto parse/validate query params and apply filtering/sorting/pagination with{ data, meta }responses. - Updates the dynamic router to generate a fixed-size mock pool and return paginated envelopes for array routes.
- Extends Swagger + README to document the new query parameters and response shape; adds Jest coverage for the query processor.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/core/queryProcessor.test.ts | Adds unit tests for query parsing, sort validation, filtering, sorting, and pagination behavior. |
| src/core/queryProcessor.ts | New core implementation for parsing query params and applying filters/sort/pagination to mock pools. |
| src/core/router.ts | Hooks query processing into array routes and switches plural responses to the {data, meta} envelope. |
| src/core/swagger.ts | Documents list query parameters and paginated list response schema in generated OpenAPI spec. |
| README.md | Documents pagination/filtering/sorting usage and shows the new envelope response format for plural routes. |
| CLAUDE.md | Adds repository workflow/architecture guidance (tooling + project structure notes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.