feat: nginx and authentication support (MAPCO-9559) #18
Conversation
…ding db to secrets
|
🎫 Related Jira Issue: MAPCO-9559 |
There was a problem hiding this comment.
Shouldn't this file be named extractable-management-secret.yaml?
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: {{ .Values.usersSecret.name }} |
There was a problem hiding this comment.
Why is this coming from the values?
There was a problem hiding this comment.
I wasn't talking about the whole secret, just the secret name being taken from the values.
There was a problem hiding this comment.
It was a mistake that was made in a different pr, as I forked my branch from it, it was removed
| name: {{ .Values.usersSecret.name }} | ||
| type: Opaque | ||
| stringData: | ||
| {{ .Values.usersSecret.key }}: | |
There was a problem hiding this comment.
Why is this coming from the values?
There was a problem hiding this comment.
I wasn't talking about the whole secret, just the key being taken from the values.
There was a problem hiding this comment.
It was a mistake that was made in a different pr, as I forked my branch from it, it was removed
helm/values.yaml
Outdated
| cpu: 100m | ||
| memory: 128Mi | ||
|
|
||
| route: |
There was a problem hiding this comment.
Should this section be under the nginx directive? Because it's missing there.
If not, the suggestions I made aren't relevant.
There was a problem hiding this comment.
This is the node service route, added nginx route.
There was a problem hiding this comment.
it is that was why it was set to false, the nginx pr made it redundant, I will delete the existing route and ingress files
| } | ||
|
|
||
| upstream extractable-management-service { | ||
| server {{ $serviceName }}:{{ .Values.env.port }}; |
4 participants
Related issues: MAPCO-9559