Skip to content

Conversation

@vitaligi
Copy link
Collaborator

@vitaligi vitaligi commented Feb 8, 2026

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

🎫 Related Jira Issue: MAPCO-9813

@vitaligi vitaligi changed the base branch from master to feat/dem-service February 8, 2026 13:20
schemas:
error:
Classification:
type: string
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it a string and not a number? with range limit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently Classification will continue to be string for cross team consistency

openapi3.yaml Outdated
- classification
properties:
classification:
$ref: '#/components/schemas/Classification'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a specific method on changing classification?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need specific instructions on publish/ unpublish

inputFiles:
allOf:
- $ref: '#/components/schemas/InputFiles'
ValidateSuccessfulResponse:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a valid response, I've expected something like:
components:
schemas:
validateResponse:
type: object
required:
- isValid
- message
- code
properties:
isValid:
type: boolean
message:
type: string
code:
type: string
enum:
- SUCCESS
- MISSING_CREDENTIALS
- INVALID_CREDENTIALS
- INVALID_RECORD_NAME
- INTERNAL_ERROR

@MapColonies MapColonies deleted a comment from asafMasa Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants