-
Notifications
You must be signed in to change notification settings - Fork 0
chore: define openapi specification for dem-gateway (MAPCO-9813) #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/dem-service
Are you sure you want to change the base?
Conversation
vitaligi
commented
Feb 8, 2026
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✖ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✖ |
| Tests added | ✖ |
| Chore | ✔ |
|
🎫 Related Jira Issue: MAPCO-9813 |
| schemas: | ||
| error: | ||
| Classification: | ||
| type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it a string and not a number? with range limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently Classification will continue to be string for cross team consistency
openapi3.yaml
Outdated
| - classification | ||
| properties: | ||
| classification: | ||
| $ref: '#/components/schemas/Classification' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a specific method on changing classification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need specific instructions on publish/ unpublish
| inputFiles: | ||
| allOf: | ||
| - $ref: '#/components/schemas/InputFiles' | ||
| ValidateSuccessfulResponse: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a valid response, I've expected something like:
components:
schemas:
validateResponse:
type: object
required:
- isValid
- message
- code
properties:
isValid:
type: boolean
message:
type: string
code:
type: string
enum:
- SUCCESS
- MISSING_CREDENTIALS
- INVALID_CREDENTIALS
- INVALID_RECORD_NAME
- INTERNAL_ERROR