-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add external to osm tag mapping v1 schema #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eyalr1100
wants to merge
10
commits into
master
Choose a base branch
from
feat/create-external-to-osm-tag-mapping-v1-schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0b395eb
feat: add external to osm tag mapping v1 schema
eyalr1100 31ce79a
fix: add redis schema reference
eyalr1100 755d76b
fix: add titles to work with ts unsafe assignments
eyalr1100 2b1e59e
fix: require values for better typing
eyalr1100 cbc79ba
fix: fix app schema properties
eyalr1100 8e49cce
fix: make tls optional
eyalr1100 8940585
fix: make tls actually optional
eyalr1100 a6b538c
fix: fix connect timeout naming and minimum
eyalr1100 c7e351a
fix: reference redis schema
eyalr1100 d33f6e9
fix: add schema config to schema
eyalr1100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't create redis schema by yourself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| { | ||
| "$id": "https://mapcolonies.com/vector/externalToOsmTagMapping/v1", | ||
| "type": "object", | ||
| "title": "vectorExternalToOsmTagMappingV1", | ||
| "description": "Mapping configuration for external vector data to OSM tags", | ||
| "allOf": [ | ||
| { "$ref": "https://mapcolonies.com/common/boilerplate/v2" }, | ||
| { "$ref": "#/definitions/databases" }, | ||
| { "$ref": "#/definitions/appSchema" } | ||
| ], | ||
| "definitions": { | ||
| "databases": { | ||
| "type": "object", | ||
| "properties": { | ||
| "db": { | ||
| "type": "object", | ||
| "required": ["redis"], | ||
| "properties": { | ||
| "redis": { | ||
| "allOf": [ | ||
| { "$ref": "https://mapcolonies.com/common/redis/v2" }, | ||
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "connectTimeoutMs": { | ||
| "type": "number", | ||
| "x-env-value": "REDIS_CONNECT_TIMEOUT", | ||
| "default": 5000, | ||
| "minimum": 500 | ||
| } | ||
| }, | ||
| "required": ["connectTimeoutMs"] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "appSchema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "application": { | ||
| "type": "object", | ||
| "required": ["hashKey"], | ||
| "properties": { | ||
| "hashKey": { | ||
| "type": "object", | ||
| "required": ["enabled"], | ||
| "properties": { | ||
| "enabled": { "type": "boolean", "x-env-value": "APP_HASHKEY_ENABLED" }, | ||
| "value": { "type": "string", "x-env-value": "APP_HASHKEY_VALUE" } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "schema": { | ||
| "type": "object", | ||
| "properties": { | ||
| "provider": { "type": "string", "x-env-value": "SCHEMA_PROVIDER" }, | ||
| "filePath": { "type": "string", "x-env-value": "SCHEMA_FILE_PATH" } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using this schema test prefix (redis key prefis) config and logic