-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add Smart Release Please action MAPCO-8998 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I want you to check Concurrency Control
I'm afraid of:
- Race conditions in version calculation
- Conflicting bot commits
- Duplicate release PRs. Please validate this assumption
According docs, the bottom line: "Use concurrency to ensure that only a single job or workflow using the same concurrency group will run at a time."
Concurrency:
group: smart-release-please-${{ github.ref }}
cancel-in-progress: false # false to queue, not cancel
-
Missing Python Setup
Official Documentation: GitHub-hosted runners include Python, but the best practice is explicit setup. -
What happens with other conventional? Like "chore"? Or if you release only "chore" from all commits, it seems it won't create or update the rc
-
It seems it ++ on each commit, if it update patch and you have 5 commits before merging to "next" branch,h the rc will be from "rc1" to rc6.6.
Can we add some basic logs \ output on the version that has been calculated before creating release-please new release candidate? for understanding and debugging? Some minimum log data
-
For debug ability, is there any option to add some "dry-run" non-default scenario so we can dispatch and check on future problems?
-
Add the mermaid 3 base flow so it will be understandable what the flow does, becaouse its complex flow that contains algorithmic calculation
-
consider reduce the test toa minimuml (test py file) and add it as part of the repo as a unit test to be sure we cover our logic (best practice as a developer :))
|
ronenkapelian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good job, a few easy requests, and one important thing about race-condition, it's critical,
Overall -> good job 💯
…/shared-workflows into smart-release-please
This reverts commit 5d3c80b.
This pull request introduces a new GitHub Action,
Smart Release Please, to automate and enforce correct semantic versioning for release candidates (RCs) on thenextbranch.This action was verified in the
squashrepository.See examples please see https://github.com/michalby24/squash/actions