Skip to content

Conversation

@netanelC
Copy link
Contributor

@netanelC netanelC commented Dec 17, 2024

Adds to the repo commitlint so the commits will fit our standards.
In addition, I added workflow that validates that the PR title also fits the standards

@shimoncohen
Copy link
Contributor

shimoncohen commented Dec 17, 2024

Please check this out for PR title as well:
https://github.com/marketplace/actions/pull-request-linter-action
If i'm not mistaken, the current workflow doesn't check the PR title (the action won't trigger when it changes anyway).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move file to configs folder as done here:
https://github.com/MapColonies/shared-workflows/pull/28/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not finished 😢

Copy link
Contributor

@shimoncohen shimoncohen Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the early review 😋 I will wait.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit config should sit on the repo itself like this

Copy link
Contributor

@shimoncohen shimoncohen Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you removed the workflow on this commit - a5434cb.
This totally changes the PR meaning from adding the workflow to simply adding commitlint.
Why not just add the workflows and enforce them for every PR here? Because I don't want us to add files like package.lock to this repo, it doesn't really belong here IMO.

Copy link
Contributor Author

@netanelC netanelC Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, but it is meaningless to enforce them in a workflow. That way, the commits are already pushed and the checks will just fail..
I want to prevent the wrong commit message from the beginning. Can you think of an alternative besides husky?

And about the pr-title workflow, it is not belong here so I opened a new PR #30

@netanelC netanelC marked this pull request as draft December 17, 2024 10:42
@netanelC netanelC changed the title feat: add commitlint workflow feat(bla): add commitlint workflow Dec 17, 2024
@netanelC netanelC changed the title feat(bla): add commitlint workflow feat: add commitlint workflow Dec 17, 2024
@netanelC netanelC marked this pull request as ready for review December 17, 2024 19:41
@netanelC netanelC requested a review from shimoncohen December 17, 2024 19:41
@netanelC netanelC changed the title feat: add commitlint workflow feat: add commitlint Dec 17, 2024
@netanelC
Copy link
Contributor Author

Won't do. As discussed, it is not good to put typescript in workflows repo

@netanelC netanelC closed this Dec 19, 2024
@shimoncohen
Copy link
Contributor

shimoncohen commented Dec 19, 2024

Won't do. As discussed, it is not good to put typescript in workflows repo

It's important to note that we said this isn't good in the current state of the repo. We still need to add the workflows for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants