-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
MDEV-38546: Automatically assign labels to lablesess PRs #4536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gkodinov
wants to merge
1
commit into
10.6
Choose a base branch
from
10.6-mdev-38456
base: 10.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
See https://github.com/gkodinov/test-github-actions: this is my test repo |
grooverdan
reviewed
Jan 13, 2026
Member
grooverdan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion only. Otherwise fine.
Member
Author
|
No preference. I can drop it if that's the consensus.
What's important for me is to have external contributions marked.
Best Regards,
Joro
… On 13 Jan 2026, at 3:51, Daniel Black ***@***.***> wrote:
@grooverdan commented on this pull request.
suggestion only. Otherwise fine.
In .github/workflows/copy-latest-pr-labels.yaml <#4536 (comment)>:
> +
+ steps:
+ - name: Copy selected labels from last PR by same author
+ uses: ***@***.***
+ with:
+ script: |
+ const { owner, repo } = context.repo;
+ const currentPr = context.payload.pull_request;
+ const author = currentPr.user.login;
+ const currentPrNumber = currentPr.number;
+
+ const allowedLabels = new Set([
+ 'External Contribution',
+ 'MariaDB Corporation',
+ 'MariaDB Foundation',
+ 'Codership']);
Do you really want to maintain Codership as a label now that MariaDB Corporation acquired it? For (unknown) reasons they seem to be developing https://github.com/mariadb-corporation/codership-mariadb-server before @janlindstrom <https://github.com/janlindstrom> merges it.
—
Reply to this email directly, view it on GitHub <#4536 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7GPBTWJEKX3DLK6MGV6CT4GRFTZAVCNFSM6AAAAACRNRYNHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNJTGM3TQNRRGY>.
You are receiving this because you were assigned.
|
e60b645 to
f07d06e
Compare
f07d06e to
008e30b
Compare
23cb987 to
8e8535c
Compare
with foundation/corporation/external contribution The MariaDB server repository uses certain pull request labels as queue markers for incoming pull requests as follows: - External Contribution: for all external contributions - MariaDB Corporation: for employees of the MariaDB corporation - MariaDB Foundation: for the employees of the MariaDB foundation Right now, when a new pull request is filed, these tags need to be applied manually. However a large % of these manual assignments can be automated by checking if the author is in https://github.com/orgs/MariaDB/teams/staff or in https://github.com/orgs/MariaDB/teams/developers. If they are in staff "MariaDB Foundation" is assigned. if they are not in staff, but are in developers, "MariaDB Corporation" is assigned. If they are in neither staff nor developers, "External Contribution" is assigned. A github workflow is created to do the assignments. It is being triggered every day at 2AM. Or it can be triggered manually. This is stage1 of the fix: it is read only and only *prints* the changes needed
8e8535c to
e514514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MariaDB server repository uses certain pull request labels as queue markers
for incoming pull requests as follows:
Right now, when a new pull request is filed, these tags need to be applied
manually.
However a large % of these manual assignments can be automated by checking
if the author is in https://github.com/orgs/MariaDB/teams/staff
or in https://github.com/orgs/MariaDB/teams/developers.
If they are in staff "MariaDB Foundation" is assigned.
if they are not in staff, but are in developers, "MariaDB Corporation" is assigned.
If they are in neither staff nor developers, "External Contribution" is assigned.
A github workflow is created to do the assignments. It is being triggered
every day at 2AM. Or it can be triggered manually.
This is stage1 of the fix: it is read only and only prints the changes needed