Conversation
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
@keyannotation documentation in the ROS 2 design document.I had to introduce the following changes in order to be able to test in local:
jekyll/jekyll:pagesdocker image, execute it the first time withdocker run -it jekyll/jekyll:pages shand do abundle install, then commit the image.docker run --rm -v $PWD:/srv/jekyll -i -t -p 4000:4000 jekyll/jekyll:pages bundle exec jekyll serve --watch --incremental --host 0.0.0.0.