Save quit tutorial on leave and rejoin on join#74
Open
akshualy wants to merge 1 commit intoMartenM:masterfrom
Open
Save quit tutorial on leave and rejoin on join#74akshualy wants to merge 1 commit intoMartenM:masterfrom
akshualy wants to merge 1 commit intoMartenM:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds methods to the DataSource to save when a user quits the server while being in a tutorial. Optionally, in the future, it could be possible to toggle this on a per-tutorial basis and it would also be nice to save the progress, so at which point of the tutorial the player left. To keep the PR short, I put these features off for now.
Notes
I tried to follow the existing code style but did do some things differently. Feel free to request changes and I'll make them.