Added time-based show and hide functionality to actionbar#82
Open
Fameless9 wants to merge 4 commits intoMartenM:masterfrom
Open
Added time-based show and hide functionality to actionbar#82Fameless9 wants to merge 4 commits intoMartenM:masterfrom
Fameless9 wants to merge 4 commits intoMartenM:masterfrom
Conversation
MartenM
requested changes
Apr 22, 2024
Owner
MartenM
left a comment
There was a problem hiding this comment.
Changes seem fair enough. I do remember the actionbar having an option to 'repeat' though. How does it interact with that functionality?
Also I am not seeing a command that allow for editing this variable. Please attach an editor that allows for this for the corresponding points. Check how this is done for the other points.
| protected List<FireWorkInfo> fireworks; | ||
| protected String message_actionBar; | ||
| protected double actionbar_show_after; | ||
| protected double actionbar_hide_after; |
Owner
There was a problem hiding this comment.
Please follow the java naming conventions (even though I messed up the message_actionBar variable).
So actionbarShowAfter and actionbarHideAfter.
Contributor
Author
|
Hi, the changes won't interfere with the repeatActionbar, however, the actionbar will never be hidden when repeatActionbar is true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds a
hide-afterandshow-afteroption to the actionbar. The runnable controlling when to show and hide the actionbar automatically cancels when the point has finished or the hide-after has been reached, so it will not lead to any overload on the server.Example:
Configuration:
ServerTutorialPlus.actionbar.mp4
show-afterandhide-aftershould both be specified in seconds