Enable adding to Nomad config from confext #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enables configuration extensions (confext) to add to Nomad's configuration by adding a new configuration directory path to the Nomad agent's command line arguments and creating the corresponding directory in the base image.
- Adds
-config=/etc/nomad.dflag to Nomad agent's systemd service - Creates the
/etc/nomad.ddirectory in the base image to prevent startup failures
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mkosi.images/nomad/systemd/nomad.service | Adds -config /etc/nomad.d flag to enable confext configuration loading |
| mkosi.images/base/mkosi.extra/etc/nomad.d/.placeholder | Creates the required directory structure with a placeholder file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hkumarmk
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-config=/etc/nomad.dto Nomad agent's command line, providing alocation for confexts to add to Nomad's configuration.
Nomad agent will fail if the directory does not exist, so add it to the
base image.