Make the demos to work with both visualisers#1
Open
vsnever wants to merge 8 commits intoMateasek:separate_visualisationfrom
Open
Make the demos to work with both visualisers#1vsnever wants to merge 8 commits intoMateasek:separate_visualisationfrom
vsnever wants to merge 8 commits intoMateasek:separate_visualisationfrom
Conversation
Mateasek
pushed a commit
that referenced
this pull request
Mar 21, 2022
Add: lens primitive sources, cylinder source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the demos, so now they work with both visualisers. Also, fixed a couple of bugs in the process, updated some docstrings and improved PEP8 conformity here and there .