resolve typing error by adding scipy-stubs as dev dependency
#34741
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA. |
Contributor
Author
|
I have read the Contributor License Agreement (CLA) and I hereby sign the CLA. |
Contributor
Author
|
recheck |
materialize-bot
added a commit
to MaterializeInc/cla
that referenced
this pull request
Jan 17, 2026
def-
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
scipy-stubsas a (Python) development dependency, which resolves the typing error that's reported when importing fromscipyinfeature_benchmark.termination.I also took the liberty of upgrading SciPy to the latest patch release of the 1.15 branch, as it contains a couple of bugfixes.