Add support for supplying a CA certificate as a PEM string #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I just found that there was already a PR opened against the upstream repo: prisma#290 - i can grab those changes instead |
ptravers
reviewed
Jun 26, 2025
| /// Will panic in case `trust_cert` or `trust_cert_ca` was called before. | ||
| /// | ||
| /// - Defaults to validating the server certificate is validated against system's certificate storage. | ||
| pub fn trust_cert_ca_pem(&mut self, cert: impl ToString) { |
There was a problem hiding this comment.
nit: maybe suffix with _string to clarify that we are passing a string literal containing a certificate?
ptravers
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new function
trust_cert_ca_pemthat will accept a PEM formatted certificate as a string.Notes
/dockerto test it, but did not include them in the PR. See the certs README for updating them.native-tlsdoesn't work didn't work on macos,rustlsandvendored-opensslare good