-
Notifications
You must be signed in to change notification settings - Fork 4
Feedback & Code Review od Mentora Zespołu (Mateusz Nowak) #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MateuszNaKodach
wants to merge
63
commits into
feedback/mentor-zespolu
Choose a base branch
from
main
base: feedback/mentor-zespolu
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
d8cd4b1
Add sass structure!
PiotrRynio c46db18
Add sass files -> Fixed last commit
PiotrRynio d1e2753
Init prettierrc
PiotrRynio be4891f
Bump node-notifier from 8.0.0 to 8.0.1 (#2)
dependabot[bot] 69e5090
#3 Configure scss support with Parcel
ee5add9
#3 Add background image
0b19a30
Bump ini from 1.3.5 to 1.3.8 in /swapi-json-server
dependabot[bot] 058795f
#38 Add HTML elements structure
DomiZet 440bcbd
#38 Main view structure rendering driven by JavaScript
PawelSzambelan 7419f71
#24 Add Player logic for asking and answering questions
MateuszNaKodach e9e78ab
Add 'Husky' & "pretty-quick"
PiotrRynio fbaf571
Test of working
PiotrRynio 618c014
Finish Logo
PiotrRynio dd26746
Merge pull request #44 from nowakprojects/automatic-precommit-code-fo…
PiotrRynio a8cc3d5
Merge branch 'develop' into UI-Komponent-Logo-Star-Wars
MateuszNaKodach 4823ecd
#28 Logika | Zapisywanie rankingu w Local Storage (#50)
annalamperska b368f41
Merge branch 'develop' into UI-Komponent-Logo-Star-Wars
PiotrRynio 7eb4af8
Merge pull request #46 from nowakprojects/UI-Komponent-Logo-Star-Wars
PiotrRynio 77a6e1f
#47 Delete useless HTML elements structure (#52)
PiotrRynio f52f11a
#27 Asnwer veryfication
PawelSzambelan efc6386
#8 Add question generator
jurecki fcdd2fa
#8 Refactor QuestionGenerator following functional programming princi…
fcc9392
Revert "#8 Refactor QuestionGenerator following functional programmin…
21ed9c6
#45 UI | Favicon.ico
PiotrRynio 8507d4a
#11_UI_Komponent_Przycisk_czerwony (#49)
DomiZet 6cec9c0
#8 Refactor QuestionGenerator following functional programming princi…
MateuszNaKodach 081869a
#13 UI komponent przycisk
tomaszdworniczak b2474d5
#14 Add GameMode component (#55)
DomiZet b71ffcd
#59 Add common render function, which can be used to render any compo…
405d888
Common btn (#62)
PiotrRynio 8d38aca
#58 Common Btn
PiotrRynio 3bc8506
Add changeText function in Button component (#64)
PiotrRynio 1952356
Destroy comp function and tests (#63)
PiotrRynio 16f737b
#17 UI Komponent | Odpowiedzi na pytanie (#65)
annalamperska 2e451e6
#32 Computer Mind
PiotrRynio 7cd00af
Quick fix of render function (#68)
tomaszdworniczak ef5677b
#18 create modal window component (#57)
PawelSzambelan 99ee970
#15 UI Komponent | Zasady gry dla wybranego trybu (#71)
annalamperska 2398275
#19 modal window content (#72)
PawelSzambelan bfdd339
# 10 UI players ranking for game mode (#78)
tomaszdworniczak e10f75d
GitHub Actions | Deploy from develop branch
57fe914
#23 Rendering components in mainContainer ( @PiotrWR & @tomdworniczak…
PiotrRynio f02a6f5
Unblock Animation (#81)
PiotrRynio 0a26f53
Fix for displaying question image and logo after build
PawelSzambelan 96d8bdf
#22 Developed game quiz view (#82)
PiotrRynio 72a0ca8
Update game quiz view (#84)
PiotrRynio dcbac85
Quiz view before merge (#86)
PiotrRynio 2780dfb
Quiz timer #21 (#70)
tomaszdworniczak adc3b5f
Fix for images (#90) change their src
PawelSzambelan dd0e59d
Fix/ranking sort added (#92)
PawelSzambelan 6527c48
Update view for modal window (#89)
PawelSzambelan d9430e4
Remove border from main view (#93)
PawelSzambelan 0415347
#73 responsivity from360×640 to 414×896 (#83)
PawelSzambelan 2641279
#74 responsivity from 601px to 1024px (#87)
PawelSzambelan 8a5aceb
#29 Logika | Quiz - przeprowadzenie rozgrywki
annalamperska fac753f
#74 Update for tablets view
PawelSzambelan 27990fc
#75 Responsiveness for 1280 1920px
tomaszdworniczak a1265e1
#20 Add lightsaber timer
DomiZet 32dfb2e
Fix for mobiles responsivity (#96)
PawelSzambelan bc28e37
Fix for times names (#97)
PawelSzambelan 9e79b8d
Fix for styles for 1280-1400px width screen (#98)
tomaszdworniczak 20e4f96
Update README.md
DomiZet 27f6ee1
README | Add presentation graphic
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,5 @@ dist | |
| .cache | ||
| node_modules | ||
| coverage | ||
| css | ||
| .history | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| { | ||
| "singleQuote": true, | ||
| "trailingComma": "all" | ||
| "trailingComma": "all", | ||
| "tabWidth": 2, | ||
| "semi": true | ||
| } | ||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,49 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="pl"> | ||
| <head> | ||
| <meta charset="UTF-8"/> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"/> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge"/> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <meta http-equiv="X-UA-Compatible" content="ie=edge" /> | ||
| <title>CodersCamp2020 | Star Wars API QUIZ</title> | ||
| <link rel="stylesheet" href="styles/App.css"/> | ||
| <link rel="stylesheet" href="sass/style.scss" /> | ||
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Montserrat:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap" | ||
| rel="stylesheet" | ||
| /> | ||
| <link | ||
| rel="apple-touch-icon" | ||
| sizes="180x180" | ||
| href="/static/assets/icons/apple-touch-icon.png" | ||
| /> | ||
| <link | ||
| rel="icon" | ||
| type="image/png" | ||
| sizes="32x32" | ||
| href="/static/assets/icons/favicon-32x32.png" | ||
| /> | ||
| <link | ||
| rel="icon" | ||
| type="image/png" | ||
| sizes="16x16" | ||
| href="/static/assets/icons/favicon-16x16.png" | ||
| /> | ||
|
|
||
| <link href="https://fonts.googleapis.com/css2?family=Montserrat:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap" | ||
| rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
| <link | ||
| rel="icon" | ||
| type="image/png" | ||
| sizes="192x192" | ||
| href="/static/assets/icons/android-chrome-192x192.png" | ||
| /> | ||
| <link | ||
| rel="icon" | ||
| type="image/png" | ||
| sizes="512x512" | ||
| href="/static/assets/icons/android-chrome-512x512.png" | ||
| /> | ||
| </head> | ||
| <body> | ||
| <div id="swquiz-app"></div> | ||
|
|
||
| <div id="swquiz-app"> | ||
| </div> | ||
|
|
||
| <script src="src/index.js"></script> | ||
| </body> | ||
| <script src="src/index.js"></script> | ||
| </body> | ||
| </html> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, że był skonfigurowany prettier! Dużo zespołów to pominęło, a to znacznie pomogło we współpracy.