-
Notifications
You must be signed in to change notification settings - Fork 0
Реализованны Модели данных и REST-контроллеры #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| package ru.yandex.practicum.filmorate.controller; | ||
|
|
||
| import jakarta.validation.Valid; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import ru.yandex.practicum.filmorate.exception.ValidationException; | ||
| import ru.yandex.practicum.filmorate.model.User; | ||
| import org.springframework.web.bind.annotation.*; | ||
|
|
||
| import java.time.LocalDate; | ||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/users") | ||
| @Slf4j | ||
| public class UserController { | ||
| private final Map<Long, User> users = new HashMap<>(); | ||
| private Long idCounter = 1L; | ||
|
|
||
| private void validateUser(User user) { | ||
| if (user.getEmail() == null || user.getEmail().isBlank() || !user.getEmail().contains("@")) { | ||
| log.warn("Электронная почта не может быть пустой и должна содержать символ @"); | ||
| throw new ValidationException("Электронная почта не может быть пустой и должна содержать символ @"); | ||
| } | ||
| if (user.getLogin() == null || user.getLogin().isBlank() || user.getLogin().contains(" ")) { | ||
| log.warn("Логин не может быть пустым и содержать пробелы"); | ||
| throw new ValidationException("Логин не может быть пустым и содержать пробелы"); | ||
| } | ||
| if (user.getName() == null || user.getName().isBlank()) { | ||
| user.setName(user.getLogin()); | ||
| log.info("Для пользователя {} установлено имя из логина", user.getLogin()); | ||
| } | ||
| if (user.getBirthday() == null || user.getBirthday().isAfter(LocalDate.now())) { | ||
| log.warn("Дата рождения не может быть в будущем"); | ||
| throw new ValidationException("Дата рождения не может быть в будущем"); | ||
| } | ||
| } | ||
|
|
||
| @PostMapping | ||
| public User createUser(@Valid @RequestBody User user) { | ||
| validateUser(user); | ||
| user.setId(idCounter++); | ||
| users.put(user.getId(), user); | ||
| log.info("Создан пользователь: {}", user); | ||
| return user; | ||
| } | ||
|
|
||
| @PutMapping | ||
| public User updateUser(@Valid @RequestBody User user) { | ||
| if (user.getId() == null || !users.containsKey(user.getId())) { | ||
| log.warn("Пользователь с id {} не найден", user.getId()); | ||
| throw new ValidationException("Пользователь с указанным id не существует"); | ||
| } | ||
| validateUser(user); | ||
| users.put(user.getId(), user); | ||
| log.info("Обновлен пользователь: {}", user); | ||
| return user; | ||
| } | ||
|
|
||
| @GetMapping | ||
| public List<User> getAllUsers() { | ||
| log.info("Получен запрос всех пользователей. Текущее количество: {}", users.size()); | ||
| return new ArrayList<>(users.values()); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package ru.yandex.practicum.filmorate.exception; | ||
|
|
||
| public class ValidationException extends RuntimeException { | ||
| public ValidationException(String message) { | ||
| super(message); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,28 @@ | ||
| package ru.yandex.practicum.filmorate.model; | ||
|
|
||
| import lombok.Getter; | ||
| import lombok.Setter; | ||
|
|
||
| /** | ||
| * Film. | ||
| */ | ||
| @Getter | ||
| @Setter | ||
| import jakarta.validation.constraints.Min; | ||
| import jakarta.validation.constraints.NotBlank; | ||
| import jakarta.validation.constraints.NotNull; | ||
| import jakarta.validation.constraints.Size; | ||
| import lombok.Data; | ||
|
|
||
| import java.time.LocalDate; | ||
|
|
||
|
|
||
| @Data | ||
| public class Film { | ||
| private Long id; | ||
|
|
||
| @NotBlank | ||
| private String name; | ||
|
|
||
| @NotBlank | ||
| @Size(min = 1, max = 200) | ||
| private String description; | ||
|
|
||
| @NotNull | ||
| private LocalDate releaseDate; | ||
|
|
||
| @Min(1) | ||
| private int duration; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| package ru.yandex.practicum.filmorate.model; | ||
|
|
||
| import jakarta.validation.constraints.Email; | ||
| import jakarta.validation.constraints.NotBlank; | ||
| import lombok.Data; | ||
|
|
||
| import java.time.LocalDate; | ||
|
|
||
| @Data | ||
| public class User { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Необязательно, на Ваше усмотрение. public class User {
@NotBlank
@Email
private String email;
@NotBlank
private String login;
............ |
||
| private Long id; | ||
|
|
||
| @NotBlank | ||
| private String email; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Обратите внимание, что для автоматической проверки нужны не только аннотации над полями класса, но и добавить аннотацию @Valid в соответствующих методах контроллера User |
||
|
|
||
| @NotBlank | ||
| private String login; | ||
| private String name; | ||
| private LocalDate birthday; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package ru.yandex.practicum.filmorate; | ||
|
|
||
| import ru.yandex.practicum.filmorate.controller.FilmController; | ||
| import ru.yandex.practicum.filmorate.controller.UserController; | ||
| import ru.yandex.practicum.filmorate.model.Film; | ||
| import ru.yandex.practicum.filmorate.model.User; | ||
| import org.junit.jupiter.api.Test; | ||
| import java.time.LocalDate; | ||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| class BoundaryTests { | ||
| private FilmController filmController = new FilmController(); | ||
| private UserController userController = new UserController(); | ||
|
|
||
| @Test | ||
| void filmValidation_BoundaryValues() { | ||
| // Проверка минимально допустимой даты релиза | ||
| Film film1 = new Film(); | ||
| film1.setName("Boundary Film"); | ||
| film1.setDescription("Desc"); | ||
| film1.setReleaseDate(LocalDate.of(1895, 12, 28)); | ||
| film1.setDuration(1); | ||
| assertDoesNotThrow(() -> filmController.addFilm(film1)); | ||
|
|
||
| // Проверка максимальной длины описания | ||
| Film film2 = new Film(); | ||
| film2.setName("Boundary Film"); | ||
| film2.setDescription("a".repeat(200)); | ||
| film2.setReleaseDate(LocalDate.of(2000, 1, 1)); | ||
| film2.setDuration(1); | ||
| assertDoesNotThrow(() -> filmController.addFilm(film2)); | ||
| } | ||
|
|
||
| @Test | ||
| void userValidation_BoundaryValues() { | ||
| // Проверка сегодняшней даты рождения | ||
| User user1 = new User(); | ||
| user1.setEmail("test@example.com"); | ||
| user1.setLogin("testlogin"); | ||
| user1.setBirthday(LocalDate.now()); | ||
| assertDoesNotThrow(() -> userController.createUser(user1)); | ||
|
|
||
| // Проверка минимально допустимого логина | ||
| User user2 = new User(); | ||
| user2.setEmail("test@example.com"); | ||
| user2.setLogin("a"); // Минимальный логин | ||
| user2.setBirthday(LocalDate.of(1990, 1, 1)); | ||
| assertDoesNotThrow(() -> userController.createUser(user2)); | ||
| } | ||
|
|
||
| @Test | ||
| void nullRequest_ThrowsException() { | ||
| assertThrows(Exception.class, () -> filmController.addFilm(null)); | ||
| assertThrows(Exception.class, () -> userController.createUser(null)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Необязательно, на Ваше усмотрение. Для этих полей можно было бы добавить ограничительные аннотации, например:
Тогда можно будет избавиться от части ручных проверок.