Jeff Takaki - Assessment Pull Request#1
Open
jeffreytakaki wants to merge 6 commits intoMeUndies:mainfrom
Open
Conversation
Set up app structure, routing, reusable components. - Update metadata and branding in layout.tsx for Shopify Product Explorer - Setup responsive layout components: - Header - Product components - Search component
+ pull in meundies branding colors + create svgs for header elements + stub out emptystate component
+ creation of essential useProducts and useSearch custom hooks. + new api route to perform graphql fetch for products in shopify backend + Define Graphql queries + Pagination component, utilizing graphql cursor based pagination + Build out of ProductGrid and ProductCard + Build out of Search component. utilize debounce function to decrease unnecessary GET calls. Add history window for past searches.
+ show page number for pagination component
+ display product images, title, description, variants (if any), placeholder Add to Cart CTA + currency helper to normalize currency display ($50 for flat or $29.99 for floats)
…testing - Memoize repeatedly rendered items for performance - Migrate homepage to SSR (initial implementation) - Fix pagination and search results behavior - Disable back button for paginated search (Shopify GraphQL limitation) - Update product modal after structure change - Minor TypeScript fixes - Add tests for useDebounce and related Jest files - add test for useSearch hook - remove clear search in product grid for UX - add cursor pointers for better UX in pagination - Linting issues - Add ReadMe notes - update button styling to match meUndies production - fix search button styling on safari
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi MeUndies team!
Thanks again to the MeUndies team for the opportunity to work on this challenge 🙏.
I have included a separate readme (Jeff_README.md) that details my approach to this assignment.
The steps to running this project locally remains the same as Darren's. I will email the keys to Connie.
For quick viewing, I deployed the project to: meundies.jeffreytakaki.com
Please let me know if you have any questions or need clarification on any part of the implementation!
Jeff Takaki