fix: always use image icon for image links, regardless of URL type#605
Open
twio142 wants to merge 1 commit intoMeanderingProgrammer:mainfrom
Open
fix: always use image icon for image links, regardless of URL type#605twio142 wants to merge 1 commit intoMeanderingProgrammer:mainfrom
twio142 wants to merge 1 commit intoMeanderingProgrammer:mainfrom
Conversation
Make sure image links always have the image icon, regardless of the link type.
Owner
|
This is intentional behavior, to prioritize custom icon definitions regardless of link type, image is just used as a fallback. |
Author
|
I think image links are essentially different to other lins. They rarely need to be manually opened, so the concrete protocol or domain are not that relevant. It's more important to be able to identify the images. I use Hope you could reconsider this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where image links (
) do not consistently display the image icon.Currently, the plugin assigns icons based on the link target:
I personally think that image links should always display the image icon, regardless of the URL type.