Resolve dummy data initialization in script #348
Merged
ansh-meesho merged 4 commits intodevelopfrom Feb 27, 2026
Merged
Conversation
…pdate main initialization script to skip these steps if the corresponding scripts are not found.Removed the variant check
WalkthroughThe changes remove two complete database initialization scripts for etcd and scylla dummy data, refactor the main initialization orchestrator to conditionally execute dummy scripts with fallback logic, and enhance MySQL verification with a two-step schema and user existence check. Changes
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@quick-start/db-init/scripts/verify-init.sh`:
- Around line 16-24: The final MySQL summary is hardcoded to assume the admin
exists; update verify-init.sh to compute a reusable status string after the
existing MySQL checks (use the ADMIN_COUNT result and the schema check) — e.g.,
set a variable like MYSQL_STATUS to either "admin user ✅" or "schema ready (no
admin user) ✅" based on ADMIN_COUNT and the table presence check, and then
reference that MYSQL_STATUS variable in the script's final summary output
instead of the fixed message; locate logic around the mysql check and the
ADMIN_COUNT variable to implement this change.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
quick-start/db-init/scripts/init-dummy-etcd.shquick-start/db-init/scripts/init-dummy-scylla.shquick-start/db-init/scripts/main-init.shquick-start/db-init/scripts/verify-init.sh
💤 Files with no reviewable changes (2)
- quick-start/db-init/scripts/init-dummy-scylla.sh
- quick-start/db-init/scripts/init-dummy-etcd.sh
ati-jn
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔁 Pull Request Template – BharatMLStack
Context:
Give a brief overview of the motivation behind this change. Include any relevant discussion links (Slack, documents, tickets, etc.) that help reviewers understand the background and the issue being addressed.
Describe your changes:
Mention the changes made in the codebase.
Testing:
Please describe how you tested the code. If manual tests were performed - please explain how. If automatic tests were added or existing ones cover the change - please explain how did you run them.
Monitoring:
Explain how this change will be tracked after deployment. Indicate whether current dashboards, alerts, and logs are enough, or if additional instrumentation is required.
Rollback plan
Explain rollback plan in case of issues.
Checklist before requesting a review
📂 Modules Affected
horizon(Real-time systems / networking)online-feature-store(Feature serving infra)trufflebox-ui(Admin panel / UI)infra(Docker, CI/CD, GCP/AWS setup)docs(Documentation updates)___________✅ Type of Change
___________📊 Benchmark / Metrics (if applicable)
Summary by CodeRabbit