Skip to content

D2M#349

Merged
ansh-meesho merged 1 commit intomainfrom
develop
Feb 27, 2026
Merged

D2M#349
ansh-meesho merged 1 commit intomainfrom
develop

Conversation

@ansh-meesho
Copy link
Contributor

@ansh-meesho ansh-meesho commented Feb 27, 2026

Resolve dummy data initialization in script

🔁 Pull Request Template – BharatMLStack

Please fill out the following sections to help us review your changes efficiently.

Context:

Give a brief overview of the motivation behind this change. Include any relevant discussion links (Slack, documents, tickets, etc.) that help reviewers understand the background and the issue being addressed.

Describe your changes:

Mention the changes made in the codebase.

Testing:

Please describe how you tested the code. If manual tests were performed - please explain how. If automatic tests were added or existing ones cover the change - please explain how did you run them.

Monitoring:

Explain how this change will be tracked after deployment. Indicate whether current dashboards, alerts, and logs are enough, or if additional instrumentation is required.

Rollback plan

Explain rollback plan in case of issues.

Checklist before requesting a review

  • I have reviewed my own changes?
  • Relevant or critical functionality is covered by tests?
  • Monitoring needs have been evaluated?
  • Any necessary documentation updates have been considered?

📂 Modules Affected

  • horizon (Real-time systems / networking)
  • online-feature-store (Feature serving infra)
  • trufflebox-ui (Admin panel / UI)
  • infra (Docker, CI/CD, GCP/AWS setup)
  • docs (Documentation updates)
  • Other: ___________

✅ Type of Change

  • Feature addition
  • Bug fix
  • Infra / build system change
  • Performance improvement
  • Refactor
  • Documentation
  • Other: ___________

📊 Benchmark / Metrics (if applicable)

Summary by CodeRabbit

  • Chores
    • Refactored the initialization process to make dummy data setup optional and flexible. The system now gracefully handles missing initialization scripts by skipping or falling back to standard configurations, improving deployment resilience.

Resolve dummy data initialization in script
@coderabbitai
Copy link

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01e8846 and ef0a830.

📒 Files selected for processing (3)
  • quick-start/db-init/scripts/init-dummy-etcd.sh
  • quick-start/db-init/scripts/init-dummy-scylla.sh
  • quick-start/db-init/scripts/main-init.sh
💤 Files with no reviewable changes (2)
  • quick-start/db-init/scripts/init-dummy-scylla.sh
  • quick-start/db-init/scripts/init-dummy-etcd.sh

Walkthrough

Removed two database initialization scripts for etcd and ScyllaDB dummy data setup. Modified the main initialization script to conditionally execute dummy database scripts, running fallback initialization scripts when dummy scripts are absent.

Changes

Cohort / File(s) Summary
Removed Dummy Database Initialization Scripts
quick-start/db-init/scripts/init-dummy-etcd.sh, quick-start/db-init/scripts/init-dummy-scylla.sh
Deleted etcd and ScyllaDB dummy data initialization scripts that previously populated test configurations, entities, and sample records.
Updated Main Initialization Script
quick-start/db-init/scripts/main-init.sh
Added conditional guards to check for presence of dummy initialization scripts before executing them. Falls back to regular init scripts for ScyllaDB and etcd when dummy scripts are missing; skips MySQL initialization if its dummy script is absent.
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Krd Checker ⚠️ Warning PR description lacks both KRD link and valid KRD exemption with Pod Type and justification. Add KRD link (KRD: [Google Doc]) or KRD exemption with Pod Type (H0/H1/H2) and justification.
✅ Passed checks (1 passed)
Check name Status Explanation
Dynamic Configuration Validation ✅ Passed PR only modifies shell scripts in quick-start/db-init/scripts/; no changes to application-dyn-*.yml files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ansh-meesho ansh-meesho merged commit aec2c74 into main Feb 27, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants