Since the string from strerror should never be modified, use const.#202
Open
spth wants to merge 1 commit intoMegaGlest:developfrom
Open
Since the string from strerror should never be modified, use const.#202spth wants to merge 1 commit intoMegaGlest:developfrom
spth wants to merge 1 commit intoMegaGlest:developfrom
Conversation
Jammyjamjamman
approved these changes
Nov 25, 2020
Contributor
Jammyjamjamman
left a comment
Jammyjamjamman
left a comment
There was a problem hiding this comment.
I think this looks ok to merge.
|
I think it's a good idea to use |
andy5995
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a very minor issue.
megaglest contains some calls to strerror where the result is assigned to a char *. However, according to the strerror specification, the string returned by strerror should never be changed, so I think it would be better to use const char * instead.
Philipp