Improve [Database] Initialize MYSQL Connection#378
Open
H0llyW00dzZ wants to merge 2 commits intoMelkeydev:mainfrom
Open
Improve [Database] Initialize MYSQL Connection#378H0llyW00dzZ wants to merge 2 commits intoMelkeydev:mainfrom
H0llyW00dzZ wants to merge 2 commits intoMelkeydev:mainfrom
Conversation
- [+] feat(mysql.tmpl): add timeout for the Ping operation during database initialization
- [+] docs(mysql.tmpl): add note about limitations in error handling for database connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Problem/Feature
This pull request addresses the need to avoid runtime confusion during MySQL connection initialization by adding a timeout to the Ping operation. Without a timeout, the application could hang indefinitely if the database is unreachable, leading to potential issues in production environments.
Description of Changes:
Checklist