Skip to content

fix(ci): add warnings when MQ pull request body or metadata is missing#985

Merged
mergify[bot] merged 1 commit intomainfrom
devs/sileht/scope-validation/I449dc4f833d56cc45b53ff16e6f3c035ce924775
Feb 24, 2026
Merged

fix(ci): add warnings when MQ pull request body or metadata is missing#985
mergify[bot] merged 1 commit intomainfrom
devs/sileht/scope-validation/I449dc4f833d56cc45b53ff16e6f3c035ce924775

Conversation

@sileht
Copy link
Member

@sileht sileht commented Feb 24, 2026

Log warnings instead of silently returning None when the merge queue
pull request has no body or no Mergify metadata in fenced blocks.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Copilot AI review requested due to automatic review settings February 24, 2026 12:28
@mergify mergify bot had a problem deploying to Mergify Merge Protections February 24, 2026 12:28 Failure
@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds warning messages to improve observability when merge queue pull requests are missing body content or Mergify metadata. The changes help diagnose optimization skips in the CI workflow by logging warnings instead of silently returning None.

Changes:

  • Added import for click module to enable console output
  • Added warning when MQ pull request body is missing
  • Added warning when MQ pull request body lacks Mergify metadata
Comments suppressed due to low confidence (1)

mergify_cli/ci/queue/metadata.py:61

  • There is an extra space in the assignment operator. It should be "ref = " with one space, not "ref = " with two spaces, to maintain consistent code formatting.
    ref =  _yaml_docs_from_fenced_blocks(body)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2026

🧪 CI Insights

Here's what we observed from your CI run for b7dc186.

🟢 All jobs passed!

But CI Insights is watching 👀

JulianMaurin
JulianMaurin previously approved these changes Feb 24, 2026
Log warnings instead of silently returning None when the merge queue
pull request has no body or no Mergify metadata in fenced blocks.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change-Id: I449dc4f833d56cc45b53ff16e6f3c035ce924775
@sileht sileht force-pushed the devs/sileht/scope-validation/I449dc4f833d56cc45b53ff16e6f3c035ce924775 branch from 88e1d07 to b7dc186 Compare February 24, 2026 14:15
@mergify mergify bot dismissed JulianMaurin’s stale review February 24, 2026 14:15

Pull request has been modified.

@mergify mergify bot deployed to Mergify Merge Protections February 24, 2026 14:15 Active
@mergify mergify bot requested a review from a team February 24, 2026 14:17
@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2026

Merge Queue Status

Rule: default


  • Entered queue2026-02-24 14:27 UTC
  • Checks passed · in-place
  • Merged2026-02-24 14:28 UTC · at b7dc1864d399b540de35d1e7d147992d01a9bc33

This pull request spent 14 seconds in the queue, including 2 seconds running CI.

Required conditions to merge

@mergify mergify bot added the queued label Feb 24, 2026
@mergify mergify bot merged commit 773db6b into main Feb 24, 2026
18 checks passed
@mergify mergify bot deleted the devs/sileht/scope-validation/I449dc4f833d56cc45b53ff16e6f3c035ce924775 branch February 24, 2026 14:28
@mergify mergify bot removed the queued label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants