Skip to content

fix(ci): simplify merge queue title extraction to reject falsy values early#986

Closed
sileht wants to merge 1 commit intomainfrom
devs/sileht/merge-queue-bug-again/I2e74237460f32d68aa5dcf0a5b1c3109019cac53
Closed

fix(ci): simplify merge queue title extraction to reject falsy values early#986
sileht wants to merge 1 commit intomainfrom
devs/sileht/merge-queue-bug-again/I2e74237460f32d68aa5dcf0a5b1c3109019cac53

Conversation

@sileht
Copy link
Member

@sileht sileht commented Feb 25, 2026

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

… early

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change-Id: I2e74237460f32d68aa5dcf0a5b1c3109019cac53
Copilot AI review requested due to automatic review settings February 25, 2026 07:34
@mergify mergify bot deployed to Mergify Merge Protections February 25, 2026 07:34 Active
@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2026

🧪 CI Insights

Here's what we observed from your CI run for 7d52f3b.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates merge-queue metadata detection to simplify pull request title extraction/validation by rejecting falsy titles earlier, aiming to skip non-merge-queue events sooner.

Changes:

  • Remove defaulting pull_request.title to "" and instead return None when title is falsy.
  • Adjust title validation flow before checking the "merge queue: " prefix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify mergify bot requested a review from a team February 25, 2026 07:37
@mergify mergify bot requested a review from a team February 25, 2026 10:27
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2026

@sileht this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Feb 26, 2026
@sileht
Copy link
Member Author

sileht commented Feb 26, 2026

It's not needed anymore, pydantic does a better job at this.

@sileht sileht closed this Feb 26, 2026
@mergify mergify bot removed the conflict label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants