fix(ci): request @devs review until review conditions are fully satisfied#989
Merged
mergify[bot] merged 1 commit intomainfrom Feb 25, 2026
Conversation
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 📃 Configuration Change RequirementsWonderful, this rule succeeded.Mergify configuration change
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for eb93f52. 🟢 All jobs passed!But CI Insights is watching 👀 |
…fied Previously, the review request rule used `#approved-reviews-by=0`, which stopped requesting @devs after the first approval — even when a second approval was still needed. Now checks the actual review conditions (DefaultReviewCond) so @devs keeps being requested until the requirements are truly met. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: I8a004dd8b97ad77417fdc2b4fa64aecbb9c8f14f
JulianMaurin
force-pushed
the
devs/JulianMaurin/fix/request-review-until-conditions-met/I8a004dd8b97ad77417fdc2b4fa64aecbb9c8f14f
branch
from
e61f097 to
eb93f52
Compare
jd
approved these changes
Feb 25, 2026
remyduthu
approved these changes
Feb 25, 2026
Contributor
Merge Queue StatusRule:
This pull request spent 8 seconds in the queue, with no time running CI. Required conditions to merge
|
mergify
bot
deleted the
devs/JulianMaurin/fix/request-review-until-conditions-met/I8a004dd8b97ad77417fdc2b4fa64aecbb9c8f14f
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the review request rule used
#approved-reviews-by=0, whichstopped requesting @devs after the first approval — even when a second
approval was still needed. Now checks the actual review conditions
(DefaultReviewCond) so @devs keeps being requested until the requirements
are truly met.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com