Skip to content

Conversation

@daflack
Copy link
Contributor

@daflack daflack commented Jan 2, 2026

Switching to cube.extract() rather than cube.extract_cube() to enable multiple models to have derived diagnostics calculated.

Fixes #1791

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

Switching to cube.extract() rather than cube.extract_cube() to
enable multiple models to have derived diagnostics calculated.

Fixes #1791
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Coverage

@daflack
Copy link
Contributor Author

daflack commented Jan 2, 2026

Looks like it has worked, and appears to work for a recipe I used that was failing due to this error requiring input fields A and B to calculate something (or at least produced a new error that will need fixing so will raise an issue for that shortly). I'm not sure if I have done exactly what you were aiming at, and am not convinced with the tests update.

@daflack daflack requested a review from jfrost-mo January 2, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow filter_multiple_cubes to output more than one cube per constraint

2 participants