Add signEIP7702Authorization and corresponding tests to hd and simple Eth keyrings by jeffsmale90 · Pull Request #182 · MetaMask/accounts

jeffsmale90 · 2025-01-30T21:50:48Z

EIP-7702 defines a new struct Authorization which represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract.

This change integrates the new signEIP7702Authorization added to eth-sig-util in MetaMask/eth-sig-util#407 to the eth-simple and eth-hd keyrings.

See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details

…imple. Fix corresponding tests in keyring-eth-hd.

packages/keyring-eth-hd/src/index.js

packages/keyring-eth-hd/test/index.js

packages/keyring-eth-simple/src/simple-keyring.ts

packages/keyring-eth-hd/src/index.js

packages/keyring-eth-simple/src/simple-keyring.test.ts

danroc · 2025-02-04T10:14:41Z

I left a few minor comments regarding the naming of some methods.

From the perspective of this PR, it LGTM. I did raise some small concerns about eth-sig-util not performing certain checks defined in the EIP. The main risk is that the transaction could be invalid, but @matthewwalsh0 confirmed that we have other checks in place to account for this.

…ce. Improve names of a few tests. Co-authored-by: Daniel Rocha <68558152+danroc@users.noreply.github.com>

… comment.

- prefer .toStrictEqual in signEip7702Authorization test - use type imports where possible

danroc · 2025-02-05T08:55:29Z

@metamaskbot publish-previews

#231) EIP-7702 defines a new struct Authorization which represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract. This change adds an optional `signEip7702Authorization` method to the `Keyring` type which is implemented on `@metamask/eth-simple-keyring` and `@metamask/eth-hd-keyring` in MetaMask/accounts#182. See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

EIP-7702 defines a new struct Authorization which represents authority to set a pointer to a contract address at an EOA - effectively making the EOA perform as a smart contract. This change integrates the new `signEip7702Authorization` method added to eth- simple and hd keyrings in MetaMask/accounts#182. This is exposed via `KeyringController.signEip7702Authorization` as well as the message handler `KeyringController:SignEip7702Authorization`. See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md for details --------- Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>

jeffsmale90 force-pushed the feat/sign-authorization branch 3 times, most recently from fbef2bf to 1e79c7f Compare January 31, 2025 01:28

jeffsmale90 marked this pull request as ready for review February 3, 2025 02:12

jeffsmale90 requested a review from a team as a code owner February 3, 2025 02:12

jeffsmale90 changed the title ~~[Draft] Add signEIP7702Authorization and corresponding tests to hd and simple Eth keyrings~~ Add signEIP7702Authorization and corresponding tests to hd and simple Eth keyrings Feb 3, 2025

jeffsmale90 mentioned this pull request Feb 3, 2025

feat: add optional signEip7702Authorization method to Keyring type MetaMask/utils#231

Merged

jeffsmale90 added 3 commits February 4, 2025 10:58

Add signEIP7702Authorization and corresponding tests to keyring-eth-hd

1620161

Add signEIP7702Authorization and corresponding tests to keyring-eth-s…

6bad5bc

…imple. Fix corresponding tests in keyring-eth-hd.

Fix issues identified by linting

d34295d

jeffsmale90 force-pushed the feat/sign-authorization branch from 1e79c7f to d34295d Compare February 3, 2025 22:07