fix: Fix React Native Playground dapp url#187
Merged
Conversation
adonesky1
previously approved these changes
Feb 25, 2026
Contributor
adonesky1
left a comment
There was a problem hiding this comment.
LGTM, amazing digging here Jiexi 🙇
Contributor
|
Do we need to change it here too? |
ffmcgee725
reviewed
Feb 26, 2026
Member
ffmcgee725
left a comment
There was a problem hiding this comment.
@adonesky1 not there directly, but in the wagmi-connector that lives under integrations/wagmi/metamask-connector.ts, and then those changes are copied over to the playgrounds that need a wagmi integration.
Contributor
Author
|
let's just leave the window.location.href polyfill in for now |
…rl' into jl/fix-react-native-playground-url
adonesky1
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes an issue where the react native playground was unable to get Solana signMessage prompts to appear on the wallet. This was caused by an value being used for the dapp url param which fails
new URL()on the wallet side. This is fixed by using a better url value.Separately, we need to investigate how we should implement better handling for malformed dapp urls.
References
Checklist