Skip to content

fix: Fix React Native Playground dapp url#187

Merged
adonesky1 merged 9 commits intomainfrom
jl/fix-react-native-playground-url
Feb 26, 2026
Merged

fix: Fix React Native Playground dapp url#187
adonesky1 merged 9 commits intomainfrom
jl/fix-react-native-playground-url

Conversation

@jiexi
Copy link
Contributor

@jiexi jiexi commented Feb 25, 2026

Explanation

Fixes an issue where the react native playground was unable to get Solana signMessage prompts to appear on the wallet. This was caused by an value being used for the dapp url param which fails new URL() on the wallet side. This is fixed by using a better url value.

Separately, we need to investigate how we should implement better handling for malformed dapp urls.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@jiexi jiexi requested a review from a team as a code owner February 25, 2026 21:17
adonesky1
adonesky1 previously approved these changes Feb 25, 2026
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, amazing digging here Jiexi 🙇

@adonesky1
Copy link
Contributor

Do we need to change it here too?

Copy link
Member

@ffmcgee725 ffmcgee725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adonesky1 not there directly, but in the wagmi-connector that lives under integrations/wagmi/metamask-connector.ts, and then those changes are copied over to the playgrounds that need a wagmi integration.

@jiexi
Copy link
Contributor Author

jiexi commented Feb 26, 2026

let's just leave the window.location.href polyfill in for now

adonesky1
adonesky1 previously approved these changes Feb 26, 2026
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1 adonesky1 merged commit ae40e71 into main Feb 26, 2026
51 checks passed
@adonesky1 adonesky1 deleted the jl/fix-react-native-playground-url branch February 26, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants