fix: bump multichain api client and add event listener clean up for notifications#60
Merged
ffmcgee725 merged 2 commits intomainfrom Dec 4, 2025
Conversation
wenfix
approved these changes
Dec 4, 2025
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
In the Firefox Extension, when a dapp disconnects, the UI updates correctly, but attempting to reconnect does not prompt the wallet pop-up for permission granting.
This happens because createDupeReqFilterStream middleware is responsible for keeping track of IDs that have been recently seen and not respond to request incoming from these matching IDs.
the proposed fix here is bumping
@metamask/multichain-api-clientto make sure we make use of the fix in this PR.References
Checklist