Skip to content
This repository was archived by the owner on Oct 16, 2025. It is now read-only.

Conversation

@jiexi
Copy link
Contributor

@jiexi jiexi commented Oct 15, 2025

This reverts commit c591a5f (Reapplies 5391380)


Note

Overhauls the dev toolchain: upgrades ESLint to v9 with new configs/plugins, moves to TypeScript 5.x, adds TypeDoc/depcheck/ts-bridge/ATTW tooling, updates Prettier to v3, and refreshes dependencies.

  • Dev toolchain sync/upgrade
    • ESLint 9: Bump core and configs (MetaMask v14), migrate plugins/resolvers (e.g., eslint-plugin-import-x, eslint-import-resolver-typescript), and update related utilities.
    • TypeScript 5.x: Update TypeScript, typescript-eslint (v8), ts-node, and supporting packages.
    • Formatting & docs: Upgrade Prettier to v3 and prettier-plugin-packagejson; add TypeDoc.
    • New tooling: Add @arethetypeswrong/cli, @ts-bridge/cli, and depcheck for dependency hygiene.
  • Dependencies: Broad dependency updates and lockfile refresh to align with core template.

Written by Cursor Bugbot for commit 5ef56a4. This will update automatically on new commits. Configure here.

@jiexi jiexi requested review from a team as code owners October 15, 2025 17:34
@socket-security
Copy link

socket-security bot commented Oct 15, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedts-expose-internals-conditionally@​1.0.0-empty.0991003778100
Added@​unrs/​resolver-binding-android-arm-eabi@​1.11.11001004182100
Added@​unrs/​resolver-binding-android-arm64@​1.11.11001004182100
Added@​unrs/​resolver-binding-darwin-arm64@​1.11.11001004187100
Added@​unrs/​resolver-binding-darwin-x64@​1.11.11001004187100
Added@​unrs/​resolver-binding-freebsd-x64@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-arm-gnueabihf@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-arm-musleabihf@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-arm64-gnu@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-arm64-musl@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-ppc64-gnu@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-riscv64-gnu@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-riscv64-musl@​1.11.11001004186100
Added@​unrs/​resolver-binding-linux-s390x-gnu@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-x64-gnu@​1.11.11001004187100
Added@​unrs/​resolver-binding-linux-x64-musl@​1.11.11001004187100
Added@​unrs/​resolver-binding-win32-arm64-msvc@​1.11.11001004187100
Added@​unrs/​resolver-binding-win32-ia32-msvc@​1.11.11001004187100
Added@​unrs/​resolver-binding-win32-x64-msvc@​1.11.11001004187100
Added@​nolyfill/​is-core-module@​1.0.391001004277100
Updatednode-releases@​2.0.14 ⏵ 2.0.23100 +11004487100
Addedobject-assign@​4.1.1671008654100
Added@​types/​parse-json@​4.0.21001005678100
Addedunicode-emoji-modifier-base@​1.0.01001006477100
Added@​pkgr/​core@​0.2.91001006485100
Added@​yarnpkg/​types@​4.0.11001006683100
Updated@​types/​graceful-fs@​4.1.5 ⏵ 4.1.910010066 +578100
Added@​unrs/​resolver-binding-wasm32-wasi@​1.11.11001006987100
Updated@​typescript-eslint/​visitor-keys@​5.62.0 ⏵ 8.46.010010071 +197 +1100
Addedcallsite@​1.0.01001007177100
Updated@​typescript-eslint/​parser@​5.62.0 ⏵ 8.46.010010071 +197 +1100
Addedrequire-package-name@​2.0.11001007177100
Updated@​babel/​helper-validator-option@​7.23.5 ⏵ 7.27.11001007189100
See 188 more rows in the dashboard

View full report

@socket-security
Copy link

socket-security bot commented Oct 15, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • commander@10.0.1
  • cosmiconfig@7.1.0
  • mz@2.7.0
  • resolve-dir@1.0.1
  • expand-tilde@2.0.2
  • global-prefix@1.0.2
  • vscode-oniguruma@1.7.0
  • shiki@0.14.7
  • @arethetypeswrong/core@0.15.1
  • @unrs/resolver-binding-wasm32-wasi@1.11.1
  • unrs-resolver@1.11.1
  • @emnapi/core@1.5.0
  • @tybys/wasm-util@0.10.1
  • napi-postinstall@0.3.4
  • @babel/helper-string-parser@7.27.1
  • @babel/helper-module-transforms@7.28.3
  • @babel/helpers@7.28.4

View full report

@Gudahtt
Copy link
Member

Gudahtt commented Oct 15, 2025

@SocketSecurity ignore npm/@arethetypeswrong/core@0.15.1
@SocketSecurity ignore npm/@emnapi/core@1.5.0
@SocketSecurity ignore npm/@tybys/wasm-util@0.10.1
@SocketSecurity ignore npm/@unrs/resolver-binding-wasm32-wasi@1.11.1
@SocketSecurity ignore npm/napi-postinstall@0.3.4
@SocketSecurity ignore npm/vscode-oniguruma@1.7.0

Network access expected for these


afterEach(() => {
jest.useRealTimers();
jest.clearAllTimers();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test Suite Timer Pollution

The test suite sets up fake timers in beforeAll but doesn't restore real timers in an afterAll hook. This means fake timers persist after the suite completes, which could lead to test pollution and affect subsequent test files.

Fix in Cursor Fix in Web

@Gudahtt
Copy link
Member

Gudahtt commented Oct 15, 2025

@SocketSecurity ignore npm/commander@10.0.1
@SocketSecurity ignore npm/unrs-resolver@1.11.1

Shell access OK, this is expected

@SocketSecurity ignore npm/mz@2.7.0

Shell and network access expected, this is OK

@Gudahtt
Copy link
Member

Gudahtt commented Oct 15, 2025

@SocketSecurity ignore npm/cosmiconfig@7.1.0
@SocketSecurity ignore npm/global-prefix@1.0.2
@SocketSecurity ignore npm/expand-tilde@2.0.2
@SocketSecurity ignore npm/resolve-dir@1.0.1

These "new authors" are from many years ago, these alerts are silly

@Gudahtt
Copy link
Member

Gudahtt commented Oct 15, 2025

@SocketSecurity ignore npm/@babel/helper-module-transforms@7.28.3
@SocketSecurity ignore npm/@babel/helper-string-parser@7.27.1
@SocketSecurity ignore npm/@babel/helpers@7.28.4

AI nonsense. The alert description even says that the code is legitimate and poses no risk, which seemingly contradicts the "Medium risk" rating.

@Gudahtt
Copy link
Member

Gudahtt commented Oct 15, 2025

@SocketSecurity ignore npm/shiki@0.14.7

Weird that a syntax highlighting library would need network access. But it appears to be for the purpose of bootstrapping a WASM bundle. And this has been published over 2 years with no reported vulnerabilities.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 849772e into main Oct 15, 2025
20 checks passed
@Gudahtt Gudahtt deleted the jl/reapply-5391380 branch October 15, 2025 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants