Replaced custom parsing logic by Uri#1169
Merged
NicolasDorier merged 1 commit intoMetacoSA:masterfrom May 18, 2023
YohDeadfall:uri-parsing
Merged
Replaced custom parsing logic by Uri#1169NicolasDorier merged 1 commit intoMetacoSA:masterfrom YohDeadfall:uri-parsing
NicolasDorier merged 1 commit intoMetacoSA:masterfrom
YohDeadfall:uri-parsing
Conversation
Contributor
|
ACK |
kiminuo
reviewed
May 18, 2023
Contributor
FTR, my ACK was a false positive, I thought I was commenting on this other PR: #1168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lontivero, that pull request replaces the current custom logic I asked you about with one provided by
Uriout of the box.Note that the pull request changes the type of an exception to be thrown by
BitcoinUriBuilderfromFormatExceptiontoUriFormatException. Still, it should be safe since the last one derives fromFormatException.