Embeds Redesign #3868
Open
Embeds Redesign #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncarazon
force-pushed
the
feat/embeds-redesign
branch
from
c929ffb to
dbe0441
Compare
ncarazon
force-pushed
the
feat/embeds-redesign
branch
from
dbe0441 to
2277a8f
Compare
ncarazon
force-pushed
the
feat/embeds-redesign
branch
from
a3d55e2 to
e090527
Compare
hlbmtc
reviewed
Dec 18, 2025
front_end/src/app/(embed)/questions/components/embed_question_card.tsx
Outdated
Show resolved
Hide resolved
hlbmtc
reviewed
Dec 18, 2025
front_end/src/app/(embed)/questions/components/embed_question_footer.tsx
Outdated
Show resolved
Hide resolved
elisescu
approved these changes
Dec 19, 2025
Contributor
There was a problem hiding this comment.
Any reason for not having this as an SVG?
cemreinanc
approved these changes
Jan 5, 2026
Comment on lines
+5
to
+8
| const QuestionTitle = forwardRef< | ||
| HTMLHeadingElement, | ||
| HTMLAttributes<HTMLHeadingElement> | ||
| >(({ children, className, ...props }, ref) => { |
Contributor
There was a problem hiding this comment.
in React 19, forwardRef is no longer necessary and you can pass the ref prop directly. (https://react.dev/reference/react/forwardRef)
ncarazon
force-pushed
the
feat/embeds-redesign
branch
from
2b69144 to
6b310f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3845
This PR implements the redesigned embeds, including:
Binary question embeds:
Text truncation
Screen.Recording.2025-12-16.at.17.16.46.mov
Continuous question embeds:
Multiple choice question embeds:
Time series question embeds:
Binary / continuous group question embeds:
Preservation of existing embed parameters/settings