-
Notifications
You must be signed in to change notification settings - Fork 24
Fix/3598/resolution diamond #3985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cemreinanc
wants to merge
8
commits into
main
Choose a base branch
from
fix/3598/resolution-diamond
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+513
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… related components fixes #3598 - Introduced centerOOBResolution prop to ContinuousAreaChart for better handling of out-of-bounds resolution display. - Updated ChartValueBox and ResolutionDiamond components to support new placement options and adjust positioning based on the centerOOBResolution prop. - Modified QuestionContinuousTile to pass centerOOBResolution prop to relevant charts.
- Updated resolution point configuration to increase size and stroke width for visual consistency. - Used ResolutionDiamond component for rendering resolution points with oob placement options (above, below, in). - Adjusted logic to determine placement of resolution points based on their values relative to bounds.
…ne and customized colors
Contributor
|
all looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context and design in #3598
CleanShot.2026-01-02.at.12.52.09.mp4
CleanShot.2026-01-02.at.12.50.15.mp4
closes #3598