Skip to content

Conversation

@cemreinanc
Copy link
Contributor

@cemreinanc cemreinanc commented Dec 30, 2025

context and design in #3598

Change Before After
Resolution diamond placement fix and animation
CleanShot.2026-01-02.at.12.52.09.mp4
CleanShot.2026-01-02.at.12.50.15.mp4
Usage of OOB resolutions in questions list (numeric) CleanShot 2026-01-02 at 12 53 12@2x CleanShot 2026-01-02 at 12 36 43@2x
Usage of OOB resolutions in question detail (numeric) CleanShot 2026-01-02 at 12 53 35@2x CleanShot 2026-01-02 at 12 37 03@2x
Usage of OOB resolutions in question detail (numeric, area chart) CleanShot 2026-01-02 at 12 53 44@2x CleanShot 2026-01-02 at 12 37 10@2x
Usage of resolution labels in questions list (date) CleanShot 2026-01-02 at 12 54 15@2x CleanShot 2026-01-02 at 12 42 08@2x
Usage of resolution labels in questions detail (date, area chart) CleanShot 2026-01-02 at 12 54 58@2x CleanShot 2026-01-02 at 12 42 26@2x
Usage of OOB resolutions in question detail (date, fan chart, mini area chart) CleanShot 2026-01-02 at 12 55 15@2x CleanShot 2026-01-02 at 12 42 57@2x
Usage of OOB resolutions in question detail (question group) CleanShot 2026-01-02 at 12 55 48@2x CleanShot 2026-01-02 at 12 43 22@2x

closes #3598

… related components

fixes #3598

- Introduced centerOOBResolution prop to ContinuousAreaChart for better handling of out-of-bounds resolution display.
- Updated ChartValueBox and ResolutionDiamond components to support new placement options and adjust positioning based on the centerOOBResolution prop.
- Modified QuestionContinuousTile to pass centerOOBResolution prop to relevant charts.
- Updated resolution point configuration to increase size and stroke width for visual consistency.
- Used ResolutionDiamond component for rendering resolution points with oob placement options (above, below, in).
- Adjusted logic to determine placement of resolution points based on their values relative to bounds.
@cemreinanc cemreinanc marked this pull request as ready for review January 2, 2026 12:09
@cemreinanc cemreinanc requested review from hlbmtc and ncarazon January 2, 2026 12:10
@aseckin
Copy link
Contributor

aseckin commented Jan 3, 2026

all looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates to out-of-bounds resolution displays

3 participants