Adds a method to set the capture session preset alongside a device change#41
Closed
dsmurfin wants to merge 3 commits intoMetalPetal:masterfrom
Closed
Adds a method to set the capture session preset alongside a device change#41dsmurfin wants to merge 3 commits intoMetalPetal:masterfrom
dsmurfin wants to merge 3 commits intoMetalPetal:masterfrom
Conversation
Member
|
I need more background of these changes. Can you provide some use cases? |
Collaborator
Author
|
The theory here was that it was beneficial to be able to set the preset and format (particularly for macOS) within the same call, but in retrospect it seems like this would be better handled outside of VideoIO. All of the required object such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also allows changes to be locked (for macOS) and the configurator to be set when switching video device
Includes change from PR #37