[Camera] Add method to switch to a specific video device#42
Merged
Conversation
dsmurfin
approved these changes
Mar 11, 2022
Collaborator
dsmurfin
left a comment
There was a problem hiding this comment.
This looks great, thank you. I will look at adding the equivalent for audio input switching.
Member
Author
|
@dsmurfin For the audio part: It behaves differently when disabling video/audio output with the current implementation. When disabling a video output, video input is kept, however disabling an audio output removes the audio input. Since no audio device selection is allowed previously, this is not a big problem - we always use the one default audio device. But now, I think it's better to unify this behavior. I suggest that we keep the audio and video inputs when disabling the outputs, and provide methods to remove the inputs (as you suggest in #36):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the discussion in #37 (comment)