Generalized include_dir to accept multiple args#94
Open
darthdeus wants to merge 5 commits intoMichael-F-Bryan:masterfrom
Open
Generalized include_dir to accept multiple args#94darthdeus wants to merge 5 commits intoMichael-F-Bryan:masterfrom
darthdeus wants to merge 5 commits intoMichael-F-Bryan:masterfrom
Conversation
|
@darthdeus Maybe you should rebranch your PR without changing crate names! But I'd love to get this into include_dir. Not sure why there is this limitation to a fixed single string?! @Michael-F-Bryan Do you have any comments? |
Author
|
Oops sorry I had to rename the crate in order to publish The only apparent solution being "republish as a new crate", which is what I did in order to be able to publish my crate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this PR should even be merged as is, I'm partially opening it in case someone else runs into this as well.
The issue being when you want to call
include_dirfrom another macro and compose the path, e.g. as