Updated Spotify to return duration in seconds#1
Open
kmikiy wants to merge 1 commit intoMichaelRow:masterfrom
Open
Updated Spotify to return duration in seconds#1kmikiy wants to merge 1 commit intoMichaelRow:masterfrom
kmikiy wants to merge 1 commit intoMichaelRow:masterfrom
Conversation
Spotify returned duration in millisecs, while iTunes returned the duration in seconds. I suggest that player should return the duration data in the same unit. I'm not sure how vox returns the data. (i dont use vox). If vox returns millisecs as well then I suggest to change iTunes to millisecs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotify returned duration in millisecs, while iTunes returned the duration in seconds. I suggest that players should return the duration data in the same unit. I'm not sure how vox returns the data. (i dont use vox). If vox returns millisecs as well then I suggest to change iTunes to millisecs.