added UNSAFE to componentWillReceiveProps methods to remove console warnings in React v16.3+#128
Closed
navivanuva wants to merge 1 commit intoMicheleBertoli:masterfrom
Closed
added UNSAFE to componentWillReceiveProps methods to remove console warnings in React v16.3+#128navivanuva wants to merge 1 commit intoMicheleBertoli:masterfrom
navivanuva wants to merge 1 commit intoMicheleBertoli:masterfrom
Conversation
added UNSAFE to componentWillReceiveProps methods to remove console warnings in React v16.3+
Owner
|
Thanks for your feedback and contribution, @navivanuva I'm closing this issue in favour of #130 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I really love using this repository for my projects, but I noticed that it has not been updated in over 3 years. The map works really great, but there's a small problem on the method componentWillReceiveProps which has been deprecated since react v1.6.3. A warning keeps popping up in the console. So, following the react docs, I added “UNSAFE_” to the methods, and it works fine when I tested it. Thanks