-
Notifications
You must be signed in to change notification settings - Fork 124
Update MediaElement documentation to include foreground service #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ne0rrmatrix
wants to merge
13
commits into
MicrosoftDocs:main
Choose a base branch
from
ne0rrmatrix:AndroidForegroundService
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5b9f275
Update MediaElement documentation to include foreground service requi…
ne0rrmatrix b6a9ff7
Fix minor error
ne0rrmatrix 4401ea3
Update MediaElement documentation to include background playback perm…
ne0rrmatrix 7aaf986
Clarify documentation for enabling background video playback in Media…
ne0rrmatrix 781942a
Add documentation for enabling foreground service in MediaElement on …
ne0rrmatrix 1c4b6d0
Update MediaElement documentation to clarify metadata setup for rich …
ne0rrmatrix 1384646
Clarify instructions for enabling rich media notifications in MediaEl…
ne0rrmatrix b42d6e1
Update docs/maui/views/MediaElement.md
ne0rrmatrix 0893474
Update docs/maui/views/MediaElement.md
ne0rrmatrix eb42327
Update docs/maui/views/MediaElement.md
ne0rrmatrix 420add9
Update docs/maui/views/MediaElement.md
ne0rrmatrix b099bb4
Update docs/maui/get-started.md
ne0rrmatrix 7aeed1b
Fix duplication
ne0rrmatrix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move the part about foreground service to it's own section, explain what it is (can even link to the Android docs on the topic) and then draw attention to requiring the permissions to be added in that section. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Idea. I will update it as suggested.