Test with BubleSort #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BubbleSort.Sort(listInt, new CompareIntInDescendingOrder()); | ||
| for (int i = 0; i < listInt.Count; ++i) | ||
| { | ||
| Assert.AreEqual(listInt[i], listCheck[i]); |
Collaborator
There was a problem hiding this comment.
Наоборот, первый параметр --- что ожидали, второй --- что получили
| { | ||
| Assert.AreEqual(listString[i], listCheck[i]); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Тестов маловато. Стоило проверить на пустом списке, на списке, где все элементы одинаковы, на null-ы в параметрах. Задача-то простая очень, время было :)
| /// <param name="compare">компаратор</param> | ||
| public static void Sort<T>(List<T> list, Comparer<T> compare) | ||
| { | ||
| var lenght = list.Count; |
| { | ||
| if (compare.Compare(list[j - 1], list[j]) >= 0) | ||
| { | ||
| //Swap(ref list[j], list[j + 1]); |
Collaborator
There was a problem hiding this comment.
Закомментированный код не нужен
| /// <typeparam name="T">тип класса</typeparam> | ||
| /// <param name="list">лист значений</param> | ||
| /// <param name="compare">компаратор</param> | ||
| public static void Sort<T>(List<T> list, Comparer<T> compare) |
Collaborator
There was a problem hiding this comment.
Лучше было принимать по интерфейсу, IComparer
| public override int Compare(int value1, int value2) | ||
| { | ||
| return value1 <= value2 ? 1 : -1 ; | ||
| } |
Collaborator
There was a problem hiding this comment.
Тут и в аналогичном месте ниже стоило использовать =>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.