SequenceOfStaples #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DedSec256
suggested changes
May 16, 2022
| open FsUnit | ||
| open Program | ||
|
|
||
| [<Test>] |
|
|
||
| [<Test>] | ||
| let TestExpTrue () = | ||
| let result = checkStaples "(({}))" |
Comment on lines
3
to
4
| let rec check (listOfExp : char List) (listOfStaples : char list) = | ||
| let charFunc x = if x = listOfStaples.Head then (check listOfExp.Tail listOfStaples.Tail) else false |
There was a problem hiding this comment.
Не очень информативно подобраны имена для параметров check и самой charFunc
| let charFunc x = if x = listOfStaples.Head then (check listOfExp.Tail listOfStaples.Tail) else false | ||
| match listOfExp with | ||
| | h :: tail when h = '[' || h = '(' || h = '{' -> (check tail (h :: listOfStaples)) | ||
| | h :: listOfExp when h = ']' && listOfStaples.Length > 0 -> charFunc '[' |
There was a problem hiding this comment.
listOfExp нигде не используется -- и это подозрительно. Кажется, можно упростить код так, чтобы charFunc не требовалась вовсе
DedSec256
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.