refactor: replace an usage of direct DOM APIs with function components in checkSelect.ts#35
Draft
yudukikun5120 wants to merge 2 commits intoMimori256:mainfrom
Draft
Conversation
Contributor
Author
|
@Mimori256 I tried to refactor the code, but I do not know which component does un-duplicate overlapped courses such as courses of foreign languages. Iz would like you to check the duplication in your environment if you are okay. |
Owner
|
The code looks fine but for some reason it doesn't work well here: compulsory courses are not excluded from the argument "courseList" of the function "checkSelect" |
Mimori256
force-pushed
the
master
branch
2 times, most recently
from
ecd3c56 to
102978c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.