Port to 1.21.1 neoforge #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age navigation and scrolling.
There was a problem hiding this comment.
Pull request overview
This pull request ports the Extra Golems mod from Minecraft 1.20.1 Forge to Minecraft 1.21.1 NeoForge. The changes primarily involve updating to the new NeoForge API and adapting to Minecraft 1.21.1's updated data structures and serialization systems.
- Migrates from Forge to NeoForge mod loader and updates API usage throughout the codebase
- Updates tag system from
#forge:to#c:(common convention tags) across all golem configuration files - Modernizes codec system, replacing deprecated
CodecwithMapCodecfor data serialization where appropriate - Updates particle and entity data structures to use new 1.21.1 format (e.g.,
value→item,Count→count)
Reviewed changes
Copilot reviewed 217 out of 426 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/main/resources/data/golems/golems/golem/*.json |
Updated tag references from Forge to common convention tags and modernized particle data format |
src/main/resources/data/c/tags/**/*.json |
Added new common convention tag files to replace removed Forge tags |
src/main/resources/data/forge/tags/**/*.json |
Removed Forge-specific tag definitions |
src/main/resources/META-INF/mods.toml |
Removed (likely replaced with NeoForge equivalent) |
src/main/resources/assets/golems/lang/*.json |
Added Japanese translation and updated Chinese translation with improved formatting |
src/main/java/**/*.java |
Updated imports, API calls, and data structures to NeoForge/1.21.1 equivalents |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't wait to add to my own server, those golems are so cute lol