Open
Conversation
Issue 1: ftr::dictionary can cause segfault when long strings are added to dictionary - When a new string is added, it's stored in out_dict via push_back() - A raw pointer from out_dict.back().c_str() is inserted into lut - When out_dict grows and reallocates its internal storage, all previously stored c_str() pointers become dangling Issue 2: Memory leak in ftr_writer destructor (entry pool) Each tx_entry contains an encoder<memory_writer> which has a std::vector<uint8_t> buffer. When free() is called on the raw memory block, these vectors are never destructed, leaking their heap-allocated storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1: ftr::dictionary can cause segfault on use-after-free
Replaced with deque ( deque guarantees pointers are not invalidated on push_back)
Issue 2: Memory leak in ftr_writer destructor (entry pool)
Each tx_entry contains an encoder<memory_writer> which has a std::vector<uint8_t> buffer. When free() is called on the raw memory block, these vectors are never destructed, leaking their heap-allocated storage
Also replaced with deque to automatically call destructors