Skip to content

Fix multifile async scope issue #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
digitalsadhu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix multifile async scope issue #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions public/javascripts/imageupload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,26 @@ angular.module('imageupload', [])
});
};

var processImage = function (file) {
//create a result object for each file in files
var imageResult = {
file: file,
url: URL.createObjectURL(file)
};

fileToDataURL(file).then(function (dataURL) {
imageResult.dataURL = dataURL;
});

if(scope.resizeMaxHeight || scope.resizeMaxWidth) { //resize image
doResizing(imageResult, function(imageResult) {
applyScope(imageResult);
});
}
else { //no resizing
applyScope(imageResult);
}
};

element.bind('change', function (evt) {
//when multiple always return an array of images
Expand All @@ -113,24 +133,7 @@ angular.module('imageupload', [])

var files = evt.target.files;
for(var i = 0; i < files.length; i++) {
//create a result object for each file in files
var imageResult = {
file: files[i],
url: URL.createObjectURL(files[i])
};

fileToDataURL(files[i]).then(function (dataURL) {
imageResult.dataURL = dataURL;
});

if(scope.resizeMaxHeight || scope.resizeMaxWidth) { //resize image
doResizing(imageResult, function(imageResult) {
applyScope(imageResult);
});
}
else { //no resizing
applyScope(imageResult);
}
processImage(files[i]);
}
});
}
Expand Down