New-isoplot-architecture-v2 #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
MitchellAcoustics
commented
May 10, 2025
MitchellAcoustics
commented
- Replaces type casting with direct parameter access using new get() method
- Introduces ParamModels dataclass for better parameter organization
- Simplifies style management with dedicated methods for grid, labels and legends
- Reduces SPI layer sample size default from 10000 to 1000
- Improves code maintainability and readability through better encapsulation
…xes to resolve unresolved method warnings
Removed redundant comments and streamlined examples for clarity across plotting methods. Improved diagonal line logic, refactored legend handling, and enhanced parameter handling for plotting/styling functions to improve maintainability and consistency.`` Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Introduce a new plotting module with a cleaner architecture based on composition. Includes the main `ISOPlot` class, various visualization layers, and supporting constants, enabling flexible and modular circumplex plotting functionality. Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
New refactoring is in the plotting/new submodule Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Consolidated layer management into `add_layer` with improved versatility, replacing multiple layer-specific methods with a unified interface. Deprecated legacy methods for backward compatibility and refined styling and subplot creation workflows for better clarity and maintainability. Updated dependencies to include `deprecated` library. Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Enhanced plotting functionality by introducing `subplot_by` for grouping data in subplots, along with options like `auto_allocate_axes`, `adjust_figsize`, and `subplot_titles`. Refactored layer rendering and documentation to incorporate these features, improving customization and usability. Updated dependencies to include `types-deprecated`. Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
- Replaces type casting with direct parameter access using new get() method - Introduces ParamModels dataclass for better parameter organization - Simplifies style management with dedicated methods for grid, labels and legends - Reduces SPI layer sample size default from 10000 to 1000 - Improves code maintainability and readability through better encapsulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.