-
-
Notifications
You must be signed in to change notification settings - Fork 9
Mitchell acoustics/issue121 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for Soundscapy v0.8.0: ISOPlot API and Soundscape Perception Indices
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
- Add CircE package availability checking and version validation - Integrate CircE package into R session initialization and management - Update package installation to handle GitHub-hosted CircE package - Modify session getter to return CircE package instance - Update tests to verify CircE package checking functionality
- Implement BFGS algorithm wrapper for circe package - Add model type enumeration and constraints handling - Update rpy2 dependency to include [all] extras - Export EQUAL_ANGLES from survey_utils module
Add CircEResult dataclass and bfgs wrapper function to public API, with improved type validation and result extraction from R circe package.
…d update imports Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Signed-off-by: Andrew Mitchell <a.j.mitchell@ucl.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
internals
Improvements to the internals like dependencies, ci, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes several changes across the codebase, mainly focused on documentation cleanup, test configuration improvements, and packaging adjustments. The most significant updates include removing or commenting out sections of the documentation, refining the optional dependency handling in test configuration, and updating the package manifest to better control included and excluded files.
Documentation cleanup and restructuring:
docs/referencedirectory, streamlining the documentation and possibly preparing for a new documentation approach. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Test configuration and dependency handling:
conftest.pylogic to support new dependency groups (r,satp) and improved how optional dependencies are checked and mapped to test directories. This allows for more precise control over which tests are run based on available dependencies. [1] [2] [3] [4] [5]CONTRIBUTING.mdto use bash syntax for clarity.Packaging and distribution:
MANIFEST.into more explicitly include and exclude files and directories, ensuring that only the necessary files are packaged and distributed.Continuous integration workflow adjustments:
tag-release.yml,test-tag-release.yml) that install thesoundscapy[all]extra, likely due to instability or issues with those installs. Also removed a version check step to simplify the release process. [1] [2] [3]Tutorial and notebook minor updates: