Merged
Conversation
zakkiyyat
requested changes
Mar 7, 2026
Contributor
zakkiyyat
left a comment
zakkiyyat
left a comment
There was a problem hiding this comment.
Please fix the merge conflicts with the target branch and we can proceed with the merge.
backend/src/routes/swipe.routes.ts
Outdated
Comment on lines
+17
to
+18
| const userIdHeader = req.header("x-user-id") | ||
| if (!userIdHeader) { |
Contributor
There was a problem hiding this comment.
Please review the POST /api/swipe implementation for robustness and production safety.
Focus on:
- input hardening for foodId and user identity values
- failure behavior and status codes for malformed IDs
- consistency of swipe/cart writes and possible partial-write scenarios
- schema/index assumptions for high-volume swipe traffic
- Flag any blocker-level issue before merge.
# Conflicts: # backend/README.md # backend/src/middleware/validate-request.middleware.ts # backend/src/models/food-item.model.ts # backend/src/models/index.ts # backend/src/routes/index.ts
zakkiyyat
approved these changes
Mar 7, 2026
Contributor
zakkiyyat
left a comment
zakkiyyat
left a comment
There was a problem hiding this comment.
LGTM. Approving for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the POST
/api/swipeendpoint to persist user swipe decisions. The endpoint accepts{ foodId: string, action: 'like' | 'pass' }and validates the payload using the Phase 1 validation middleware. When a user passes, the swipe is recorded in theUserSwipecollection. When a user likes an item, the swipe is recorded and a corresponding entry is created in theCartItem/Matchcollection tied to the user’s active session. The endpoint also verifies that the providedfoodIdexists and returns 404 Not Found if it does not, ensuring reliable database writes and proper error handling.closes #152