Merged
Conversation
zakkiyyat
requested changes
Mar 7, 2026
Contributor
zakkiyyat
left a comment
zakkiyyat
left a comment
There was a problem hiding this comment.
Reviewed the changes and they look good. Once the conflicts are addressed, this can be merged.
Comment on lines
+5
to
+9
| const upload = multer({ | ||
| storage: multer.memoryStorage(), | ||
| limits: { fileSize: 5 * 1024 * 1024 }, | ||
| }) | ||
|
|
Contributor
There was a problem hiding this comment.
add strict MIME allowlist enforcement in the upload route (jpeg/png/webp check), focus on
- MIME type allowlist enforcement (image/jpeg, image/png, image/webp)
- File size validation behavior and response shape
- S3 key/public URL safety and error handling
- Env var assumptions and missing-config behavior
# Conflicts: # README.md # backend/README.md # backend/package.json # backend/src/middleware/error.middleware.ts # backend/src/routes/index.ts
zakkiyyat
approved these changes
Mar 7, 2026
Contributor
zakkiyyat
left a comment
zakkiyyat
left a comment
There was a problem hiding this comment.
The requested changes have been applied and everything looks good from my side. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image upload endpoint that allows restaurants to upload high-quality food images. Images are not stored directly in the database; instead they are uploaded to cloud storage and the public URL is returned.
Changes Implemented
Implemented validation for:
closes #143