-
Notifications
You must be signed in to change notification settings - Fork 135
Updated gamekit to ios 10.1 #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great, thanks a lot! You finally mastered bro-gen ;-) I'll take a look in the next days. |
|
Some comments ive left in the yaml might say otherwise |
|
Status of this PR: Currently there are several methods generated with a trailing We need to resolve this issue in https://github.com/CoderBaron/robovm-bro-gen or find a workaround. Any help appreciated. |
|
Ive fixed the all $ and invalid |
|
@piotr-j Thanks for the update. I got compile errors with classes extending NSError: GKError, GKSessionError and GKVoiceChatServiceError: The current implementation looks a bit different: All those classes need to implement the NSError(SkipInit skipInit) constructor, than it works. Furthermore it seems the GKErrorCode class needs to implement NSErrorCode: https://github.com/MobiDevelop/robovm/blob/master/compiler/cocoatouch/src/main/java/org/robovm/apple/gamekit/GKErrorCode.java When I change those things manually, it builds fine, can we get this automagically from bro-gen, at least the constructors and extension of NSErrorCode? |
|
Ah yes, Ive totally forgot about this. Ive had to modify those manually in previous commits. |
|
@piotr-j Merged it and fixed those things manually. Thanks for your work, it's appreciated! |
Ive updated gamekit.yaml based mainly on last @CoderBaron pr. Added new apis and updated marshaler stuff mainly. Probably horribly broken.